[PATCH] mmc: sdhci-s3c: Add device tree support
Chris Ball
cjb at laptop.org
Fri Aug 17 01:47:03 EST 2012
Hi Thomas,
On Thu, Aug 16 2012, Thomas Abraham wrote:
> Add device tree based discovery support for Samsung's sdhci controller
>
> Cc: Ben Dooks <ben-linux at fluff.org>
> Cc: Kukjin Kim <kgene.kim at samsung.com>
> Cc: Chris Ball <cjb at laptop.org>
> Signed-off-by: Thomas Abraham <thomas.abraham at linaro.org>
> ---
> drivers/mmc/host/sdhci-s3c.c | 146 ++++++++++++++++++++++++++++++++++++++++--
> 1 files changed, 140 insertions(+), 6 deletions(-)
I know your initial version was submitted before we adopted a set of
standard MMC DT bindings, but now that those bindings exist this code
should be using them -- there should be a new file:
Documentation/devicetree/bindings/mmc/sdhci-s3c.txt
describing differences between the mmc.txt bindings and this driver's.
Also, you didn't include a patch changelog, so I can't tell whether this
contains changes against your v3 of this patch; please do that.
Thanks!
- Chris.
--
Chris Ball <cjb at laptop.org> <http://printf.net/>
One Laptop Per Child
More information about the devicetree-discuss
mailing list