[PATCH v3 08/10] of/address: Handle #address-cells > 2 specially
Rob Herring
robherring2 at gmail.com
Wed Aug 1 06:18:43 EST 2012
On 07/26/2012 02:55 PM, Thierry Reding wrote:
> When a bus specifies #address-cells > 2, of_bus_default_map() now
> assumes that the mapping isn't for a physical address but rather an
> identifier that needs to match exactly.
>
> This is required by bindings that use multiple cells to translate a
> resource to the parent bus (device index, type, ...).
>
> See here for the discussion:
>
> https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-June/016577.html
>
> Originally-by: Arnd Bergmann <arnd at arndb.de>
> Signed-off-by: Thierry Reding <thierry.reding at avionic-design.de>
Acked-by: Rob Herring <rob.herring at calxeda.com>
> ---
> Changes in v3:
> - new patch
>
> drivers/of/address.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/of/address.c b/drivers/of/address.c
> index 7e262a6..2776119 100644
> --- a/drivers/of/address.c
> +++ b/drivers/of/address.c
> @@ -69,6 +69,14 @@ static u64 of_bus_default_map(u32 *addr, const __be32 *range,
> (unsigned long long)cp, (unsigned long long)s,
> (unsigned long long)da);
>
> + /*
> + * If the number of address cells is larger than 2 we assume the
> + * mapping doesn't specify a physical address. Rather, the address
> + * specifies an identifier that must match exactly.
> + */
> + if (na > 2 && memcmp(range, addr, na * 4) != 0)
> + return OF_BAD_ADDR;
> +
> if (da < cp || da >= (cp + s))
> return OF_BAD_ADDR;
> return da - cp;
>
More information about the devicetree-discuss
mailing list