pata_of_platform.c cannot build on sparc

Jeff Garzik jeff at garzik.org
Thu Dec 22 12:40:33 EST 2011


On 12/21/2011 07:14 PM, David Miller wrote:
> From: Rob Herring<robherring2 at gmail.com>
> Date: Wed, 21 Dec 2011 17:25:15 -0600
>
>> On 12/21/2011 04:38 PM, David Miller wrote:
>>>
>>> It depends upon CONFIG_OF_IRQ which not all CONFIG_OF platforms support,
>>> in particular sparc does not support CONFIG_OF_PLATFORM because it
>>> precomputes all IRQs at boot time when it scans the device tree so all
>>> of the CONFIG_OF_IRQ infrastructure to probe and resolve IRQs at driver
>>> probe time is wrong and completely unnecessary.
>>>
>>> Add the proper dependencies so that pata_of_platform.c doesn't get
>>> built on sparc.
>>>
>>> CONFIG_OF_IRQ was severely misdesigned, it should just NOP out on
>>> platforms where the architecture has the final IRQ values already like
>>> sparc does.  But that's not how it was implemented at all, and now
>>> we're starting to have all of these drivers get hard dependencies on
>>> this mechanism and it's datastructures, and the resulting sparc build
>>> failures from time to time.
>>>
>>> Jeff, please push something like the following to Linus so that
>>> sparc's allmodconfig builds again.  Thanks.
>>>
>>
>> Really, drivers should no longer use of_irq_to_resource (or
>> of_address_to_resource for that matter). The resources are setup by the
>> core OF code. The patch I sent does this.
>
> Thanks for taking care of this.

Being so late in 3.2-rc, it would be preferred to apply&push David's 
patch for 3.2, and then get Rob's into libata-dev#upstream (linux-next).

That OK?

	Jeff






More information about the devicetree-discuss mailing list