[PATCH] of/pdt: fix section mismatch warning

Rob Herring robherring2 at gmail.com
Wed Dec 28 09:54:07 EST 2011


On 12/27/2011 04:29 PM, David Miller wrote:
> From: Sam Ravnborg <sam at ravnborg.org>
> Date: Tue, 27 Dec 2011 23:26:58 +0100
> 
>> We have two implementations of kernel_tree_alloc() - one in fdt.c and
>> another in pdt.c.
>>
>> $ grep kernel_tree_alloc *
>> fdt.c:static void *kernel_tree_alloc(u64 size, u64 align)
>> fdt.c:  __unflatten_device_tree(device_tree, mynodes, &kernel_tree_alloc);
>> pdt.c:static void * __init kernel_tree_alloc(u64 size, u64 align)
>> pdt.c:  of_alias_scan(kernel_tree_alloc);
>>
>> The version in fdt.c is using kzalloc() whereas the version in pdt.c
>> uses prom_early_alloc().
>>
>> And of_fdt_unflatten_tree() uses the version in fdt.c - so the patch is OK.
>>
>> It is confusing that they have the same name - but I did nto fix that.
>> And I forgot about this detail when I wrote the changelog.
> 
> Ok, I hadn't realized this, thanks for explaining.
> 
> I think Grant should apply your patch then:
> 
> Acked-by: David S. Miller <davem at davemloft.net>
> _______________________________________________

I've applied it for 3.3 unless you think it needs to go into 3.2.

Rob


More information about the devicetree-discuss mailing list