[PATCH] of/pdt: fix section mismatch warning

David Miller davem at davemloft.net
Wed Dec 28 09:29:21 EST 2011


From: Sam Ravnborg <sam at ravnborg.org>
Date: Tue, 27 Dec 2011 23:26:58 +0100

> We have two implementations of kernel_tree_alloc() - one in fdt.c and
> another in pdt.c.
> 
> $ grep kernel_tree_alloc *
> fdt.c:static void *kernel_tree_alloc(u64 size, u64 align)
> fdt.c:  __unflatten_device_tree(device_tree, mynodes, &kernel_tree_alloc);
> pdt.c:static void * __init kernel_tree_alloc(u64 size, u64 align)
> pdt.c:  of_alias_scan(kernel_tree_alloc);
> 
> The version in fdt.c is using kzalloc() whereas the version in pdt.c
> uses prom_early_alloc().
> 
> And of_fdt_unflatten_tree() uses the version in fdt.c - so the patch is OK.
> 
> It is confusing that they have the same name - but I did nto fix that.
> And I forgot about this detail when I wrote the changelog.

Ok, I hadn't realized this, thanks for explaining.

I think Grant should apply your patch then:

Acked-by: David S. Miller <davem at davemloft.net>


More information about the devicetree-discuss mailing list