[Cbe-oss-dev] [PATCH 1:6] spufs: fix pointer reference in find_victim

[Gerhard Stenzel]

> Oops, this obviosuly correct.
>
> On Mon, May 12, 2008 at 02:36:59PM +0000, Luke Browning wrote:
> > Fix pointer reference in find_victim().
> >
> > If victim (not ctx) is in spu_run, add victim to rq.
> >
> > Signed-off-by: Luke Browning <lukebrowning at us.ibm.com>
> >
> > ---
> >
> > Index: spufs/arch/powerpc/platforms/cell/spufs/sched.c
> > ===================================================================
> > --- spufs.orig/arch/powerpc/platforms/cell/spufs/sched.c
> > +++ spufs/arch/powerpc/platforms/cell/spufs/sched.c
> > @@ -657,7 +657,7 @@ static struct spu *find_victim(struct sp
> >
> >           victim->stats.invol_ctx_switch++;
> >           spu->stats.invol_ctx_switch++;
> > -         if (test_bit(SPU_SCHED_SPU_RUN, &ctx->sched_flags))
> > +         if (test_bit(SPU_SCHED_SPU_RUN, &victim->sched_flags))
> >              spu_add_to_rq(victim);
> >
> >           mutex_unlock(&victim->state_mutex);
> >
> _______________________________________________
> cbe-oss-dev mailing list
> cbe-oss-dev at ozlabs.org
> https://ozlabs.org/mailman/listinfo/cbe-oss-dev

The patch which introduced this causes testcases to fail and is already in
2.6.26-rc2. Will we able to get this fix in as well for 2.6.26?

Best regards,

Gerhard Stenzel, Linux on Cell Development, LTC
-----------------------------------------------------------------------------------------------------------------------------------

IBM Deutschland Entwicklung GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter | Geschäftsführung: Herbert
Kircher
Sitz der Gesellschaft: Böblingen | Registergericht: Amtsgericht Stuttgart,
HRB 243294