[Cbe-oss-dev] [PATCH 1:6] spufs: fix pointer reference in find_victim

[Michael Ellerman]

On Thu, 2008-05-15 at 10:13 +0200, Gerhard Stenzel wrote:
> On Tue, 2008-05-13 at 11:03 +0200, Christoph Hellwig wrote:
> > Oops, this obviosuly correct.
> >
> > On Mon, May 12, 2008 at 02:36:59PM +0000, Luke Browning wrote:
> > > Fix pointer reference in find_victim().
> > >
> > > If victim (not ctx) is in spu_run, add victim to rq.
> > >
> > > Signed-off-by: Luke Browning <lukebrowning at us.ibm.com>
> > >
> > > Index: spufs/arch/powerpc/platforms/cell/spufs/sched.c
> > > ===================================================================
> > > --- spufs.orig/arch/powerpc/platforms/cell/spufs/sched.c
> > > +++ spufs/arch/powerpc/platforms/cell/spufs/sched.c
> > > @@ -657,7 +657,7 @@ static struct spu *find_victim(struct sp
> > >
> > >           victim->stats.invol_ctx_switch++;
> > >           spu->stats.invol_ctx_switch++;
> > > -         if (test_bit(SPU_SCHED_SPU_RUN, &ctx->sched_flags))
> > > +         if (test_bit(SPU_SCHED_SPU_RUN, &victim->sched_flags))
> > >              spu_add_to_rq(victim);
> > >
> > >           mutex_unlock(&victim->state_mutex);
> 
> The patch which introduced this causes testcases to fail and is already in
> 2.6.26-rc2. Will we able to get this fix in as well for 2.6.26?

Well Jeremy should be back before the merge window closes, but I'll
pester Paulus to merge this earlier, a proper ACK from Christoph might
help.

And Luke there's no issue with this going in before the rest of the
series correct?

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/cbe-oss-dev/attachments/20080515/6b932b68/attachment.pgp>