[Cbe-oss-dev] [PATCH 1:6] spufs: fix pointer reference in find_victim

Christoph Hellwig hch at lst.de
Tue May 13 19:03:15 EST 2008


Oops, this obviosuly correct.

On Mon, May 12, 2008 at 02:36:59PM +0000, Luke Browning wrote:
> Fix pointer reference in find_victim().
> 
> If victim (not ctx) is in spu_run, add victim to rq.
> 
> Signed-off-by: Luke Browning <lukebrowning at us.ibm.com>
> 
> ---
> 
> Index: spufs/arch/powerpc/platforms/cell/spufs/sched.c
> ===================================================================
> --- spufs.orig/arch/powerpc/platforms/cell/spufs/sched.c
> +++ spufs/arch/powerpc/platforms/cell/spufs/sched.c
> @@ -657,7 +657,7 @@ static struct spu *find_victim(struct sp
>  
>  			victim->stats.invol_ctx_switch++;
>  			spu->stats.invol_ctx_switch++;
> -			if (test_bit(SPU_SCHED_SPU_RUN, &ctx->sched_flags))
> +			if (test_bit(SPU_SCHED_SPU_RUN, &victim->sched_flags))
>  				spu_add_to_rq(victim);
>  
>  			mutex_unlock(&victim->state_mutex);
> 



More information about the cbe-oss-dev mailing list