[Cbe-oss-dev] [RFC/PATCH 2/2] spufs: Add a "capabilities" file to spu contexts

[Ulrich Weigand]

Hi Ben,

this looks fine to me.  One point:

> +   if (!(ctx->flags & SPU_CREATE_NOSCHED))
> +      ADD_ONE_CAP(sched);
> +   if (!(ctx->flags & SPU_CREATE_ISOLATE))
> +      ADD_ONE_CAP(step);

I understand that when running under the simulator, single-stepping
is not supported.  Should you not also check for this, and not report
the step capability in that case?


Mit freundlichen Gruessen / Best Regards

Ulrich Weigand

-- 
  Dr. Ulrich Weigand | Phone: +49-7031/16-3727
  GNU compiler/toolchain for Linux on System z and Cell BE
  IBM Deutschland Entwicklung GmbH
  Vorsitzender des Aufsichtsrats: Martin Jetter | Geschäftsführung: 
Herbert Kircher
  Sitz der Gesellschaft: Böblingen | Registergericht: Amtsgericht 
Stuttgart, HRB 243294
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/cbe-oss-dev/attachments/20070528/c1dfb35e/attachment.htm>