[Cbe-oss-dev] [RFC/PATCH 2/2] spufs: Add a "capabilities" file to spu contexts

[Jeremy Kerr]

Ben,

> +

Free newline with every patch! This month only!

> +#define ADD_ONE_CAP(name)      \
> +  do { p += snprintf(p, CAPS_BUF_LEN - 3 - (p - buffer), "%s ", #name); \
> +     } while(0)

I know it's a pretty minor nitpick, but using the 'buffer' and 'p'
variables in this scope irks me. How about something like:

#define ADD_ONE_CAP(name, ptr, buf) ...

.. or even a separate function, as we don't need to use the
un-strigified 'name' anywhere.

Otherwise, the caps stuff looks good.


Jeremy