[Cbe-oss-dev] [RFC/PATCH 2/2] spufs: Add a "capabilities" file to spu contexts

Benjamin Herrenschmidt benh at kernel.crashing.org
Tue May 29 06:52:42 EST 2007


On Mon, 2007-05-28 at 13:11 +0200, Ulrich Weigand wrote:
> this looks fine to me.  One point: 
> 
> > +   if (!(ctx->flags & SPU_CREATE_NOSCHED))
> > +      ADD_ONE_CAP(sched);
> > +   if (!(ctx->flags & SPU_CREATE_ISOLATE))
> > +      ADD_ONE_CAP(step);
> 
> I understand that when running under the simulator, single-stepping 
> is not supported.  Should you not also check for this, and not report 
> the step capability in that case? 

Sure, I didn't know about that "feature" of the sim. Any chance you can
test if it works properly btw ?

Cheers,
Ben.





More information about the cbe-oss-dev mailing list