[Cbe-oss-dev] [PATCH 2/2] spufs: Remove spurious WARN_ON for spu_deactivate for NOSCHED contexts

Arnd Bergmann arnd at arndb.de
Tue Jul 17 05:07:44 EST 2007


On Monday 16 July 2007, Michael Ellerman wrote:
> 
> > Yeah, this is probably fine.  Alternatively spu_deactivate could grow
> > a final argument and we could keep the WARN_ON for !final.
> 
> The core dump code wants to call it too. Although we need to remove the
> explicit check for NOSCHED in the coredump code.

IIRC, time we discussed this the conclusion was that NOSCHED tasks
should not dump core, as that just creates extra special cases
and you can't debug them anyway.

	Arnd <><



More information about the cbe-oss-dev mailing list