[Cbe-oss-dev] [PATCH 2/2] spufs: Remove spurious WARN_ON for spu_deactivate for NOSCHED contexts

[Michael Ellerman]

On Mon, 2007-07-16 at 09:38 +0200, Christoph Hellwig wrote:
> On Mon, Jul 16, 2007 at 03:55:13PM +1000, Jeremy Kerr wrote:
> > In 6cbf93960e64f313f6e247cbca7afaa50e3ee2c we added a WARN_ON for
> > calling spu_deactivate on contexts created with the SPU_CREATE_NOSCHED
> > flag. However, all NOSCHED contexts will need to be deactivated when
> > the context is destroyed, so this gives a spurious warning when any
> > NOSCHED context is closed.
> > 
> > This change removes the WARN_ON.
> 
> 
> Yeah, this is probably fine.  Alternatively spu_deactivate could grow
> a final argument and we could keep the WARN_ON for !final.

The core dump code wants to call it too. Although we need to remove the
explicit check for NOSCHED in the coredump code.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/cbe-oss-dev/attachments/20070716/aa9147f2/attachment.pgp>