[Cbe-oss-dev] [PATCH 2/2] spufs: Remove spurious WARN_ON for spu_deactivate for NOSCHED contexts

[Michael Ellerman]

On Mon, 2007-07-16 at 21:07 +0200, Arnd Bergmann wrote:
> On Monday 16 July 2007, Michael Ellerman wrote:
> > 
> > > Yeah, this is probably fine.  Alternatively spu_deactivate could grow
> > > a final argument and we could keep the WARN_ON for !final.
> > 
> > The core dump code wants to call it too. Although we need to remove the
> > explicit check for NOSCHED in the coredump code.
> 
> IIRC, time we discussed this the conclusion was that NOSCHED tasks
> should not dump core, as that just creates extra special cases
> and you can't debug them anyway.

That's the point. You _should_ be able to dump them and you _should_ be
able to debug them. If I nice(1) a process it doesn't all of a sudden
become undebuggable.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/cbe-oss-dev/attachments/20070717/fa3c027f/attachment.pgp>