[Cbe-oss-dev] [PATCH 2/2] spufs: Remove spurious WARN_ON for spu_deactivate for NOSCHED contexts

Christoph Hellwig hch at lst.de
Mon Jul 16 17:38:05 EST 2007


On Mon, Jul 16, 2007 at 03:55:13PM +1000, Jeremy Kerr wrote:
> In 6cbf93960e64f313f6e247cbca7afaa50e3ee2c we added a WARN_ON for
> calling spu_deactivate on contexts created with the SPU_CREATE_NOSCHED
> flag. However, all NOSCHED contexts will need to be deactivated when
> the context is destroyed, so this gives a spurious warning when any
> NOSCHED context is closed.
> 
> This change removes the WARN_ON.


Yeah, this is probably fine.  Alternatively spu_deactivate could grow
a final argument and we could keep the WARN_ON for !final.



More information about the cbe-oss-dev mailing list