[Cbe-oss-dev] Correct way to format spufs file output.

Benjamin Herrenschmidt benh at kernel.crashing.org
Sat Oct 21 11:44:08 EST 2006


On Fri, 2006-10-20 at 16:04 +0200, Ulrich Weigand wrote:
> 
> Dwayne McConnell wrote:
> 
> > I think %0xllx is the way to go. I would even advocate changing 
> > signal1_type and signal2_type unless it is actually too dangerous.
> Is 
> > there even a case where changing from %llu to %0xllx would break
> things? 
> > Perhaps with the combination of a old library with a new kernel? 
> 
> Yes, these files are in fact used, and a change would break things. 

In the case of output in hex without 0x, well, those files are used by
code that is either assuming it's hex or is already broken. Adding 0x
might not actually break things, it depends what the use code does. If
such code does strto(u)l, then adding 0x will still work.

What do you think is the situation on user space ?

> Also, I really think this is a different issue:  having some files 
> in *decimal* and some in *hex* is fine.  What's a problem is files 
> *in hex but without the 0x prefix*.  This can be quite confusing 
> if the hex number happens to not contain any a-f digits ... 
> 
> 
> Mit freundlichen Gruessen / Best Regards
> 
> Ulrich Weigand
> 
> -- 
>  Dr. Ulrich Weigand
>  GNU compiler/toolchain for Linux on System z and Cell BE
>  IBM Deutschland Entwicklung GmbH, Schoenaicher Str. 220, 71032
> Boeblingen
>  Phone: +49-7031/16-3727   ---   Email: Ulrich.Weigand at de.ibm.com 
> _______________________________________________
> cbe-oss-dev mailing list
> cbe-oss-dev at ozlabs.org
> https://ozlabs.org/mailman/listinfo/cbe-oss-dev




More information about the cbe-oss-dev mailing list