Rewrite of ofpath

Joseph Jezak josejx at gentoo.org
Tue Feb 15 01:00:46 EST 2011


On 02/14/11 01:23, Rick Thomas wrote:
> Hi Joseph!
>
> I've only looked at your patch, not given it a thorough test yet.  But
> I've got a couple of questions...
>
> 1) It looks like you set REAL_DEV and then immediately re-set it to a
> different value.
>
> 2) I think your code to set CONTROLLER_PATH can't possibly work. 
> There is file called "devspec" on my newworld Mac where you seem to be
> looking.
>
> Can you send me a copy of the fully-patched code?  I'm not familiar
> enough with git to get it myself.
>
> Thanks!
>
> Rick
>
1) Whoops, you're absolutely right about REAL_DEV, I copy and pasted the
code from the last version and forgot to use REAL_DEV throughout the new
code so it wouldn't conflict with the DEVICE variable in the old code.
This is fixed in the attached patch.

2) I'm not sure why you think CONTROLLER_PATH can't work, can you be
more specific? It's trying to read the devspec file. It does work on my
PB G4.

I'll send a patched copy of ofpath to you in a following email.

-Joe
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ofpath_patch
URL: <http://lists.ozlabs.org/pipermail/yaboot-devel/attachments/20110214/1e149b8b/attachment.ksh>


More information about the Yaboot-devel mailing list