Rewrite of ofpath

[Rick Thomas]

Hi Joseph!

I've only looked at your patch, not given it a thorough test yet.  But  
I've got a couple of questions...

1) It looks like you set REAL_DEV and then immediately re-set it to a  
different value.

2) I think your code to set CONTROLLER_PATH can't possibly work.   
There is file called "devspec" on my newworld Mac where you seem to be  
looking.

Can you send me a copy of the fully-patched code?  I'm not familiar  
enough with git to get it myself.

Thanks!

Rick


On Feb 14, 2011, at 12:04 AM, Joseph Jezak wrote:

> On 09/16/10 11:40, Roman Rakus wrote:
>> At first, thanks for the interest and for "patch".
>> I will take a deeper look later, so now just only a few notes:
>> Better will be to send git commits (by `git format-patch' and `git
>> send-email')
>> Better is to use `printf' instead of `echo'
>> From the code:
>>
>> ### Set this to 1 to turn on debugging messages
>> DEBUG=0
>>
>>
>> I will not set DEBUG variable here. So we can use `DEBUG=1  
>> ofpath ...'
>> call.
>>
>> Anyway, it needs deeper investigation.
>>
>> RR
>> _______________________________________________
>> Yaboot-devel mailing list
>> Yaboot-devel at lists.ozlabs.org
>> https://lists.ozlabs.org/listinfo/yaboot-devel
>>
> Since I haven't heard back, I adapted my code to the original ofpath
> after some concern from the Debian project that I had gotten rid of
> legacy code. Here is the patch that implements this against the  
> current
> git head.
>
> <ofpath.patch>_______________________________________________
> Yaboot-devel mailing list
> Yaboot-devel at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/yaboot-devel