Rewrite of ofpath

[Joseph Jezak]

 On 09/16/10 11:40, Roman Rakus wrote:
>  On 09/16/2010 03:49 PM, Joseph Jezak wrote:
>>   Hi,
>>
>> The new macio pata drivers do not make an entry in /proc/scsi like other
>> scsi devices and as a result, ofpath screws up pretty badly when trying
>> to figure out the open firmware path for these devices. Other pata
>> drivers are probably also hit with the same issue, but this is all I've
>> got to test on at the moment.
>>
>> In any case, I've rewritten ofpath to take this into account and clean
>> up some of the cruft from the old version. I've only tested it on a
>> Powerbook G4 and a Quad G5, so I don't expect it'll work for everyone,
>> but I'd appreciate feedback either way.
>>
>> Thanks!
>> -Joe
> At first, thanks for the interest and for "patch".
> I will take a deeper look later, so now just only a few notes:
> Better will be to send git commits (by `git format-patch' and `git
> send-email')
Sure, but I do not think it's tested enough to replace the existing
ofpath yet. This was more of a float to see if a rewrite was okay and if
the code actually works for people.

> Better is to use `printf' instead of `echo'
Okay.

> From the code:
>
> ### Set this to 1 to turn on debugging messages
> DEBUG=0
>
> I will not set DEBUG variable here. So we can use `DEBUG=1 ofpath ...'
> call.
>
Sure. As I said before, it's certainly not complete, including the UI.

> Anyway, it needs deeper investigation.
Thanks for taking a look.

-Joe