[SLOF] [PATCH] libc: Add missing fallthrough annotation

[Segher Boessenkool]

On Mon, Jan 25, 2021 at 08:01:43AM +0100, Thomas Huth wrote:
> On 24/01/2021 09.57, Segher Boessenkool wrote:
> >>With new versions of GCC, they often added "experimental"
> >>warnings with -Wextra which were just wrong in many cases.
> >
> >Like?  I don't remember any noisy warnings added to -Wextra in the last
> >few years.
> 
> It's been quite a while since I made that experience, so I can't remember 
> the details (it was likely in the days of GCC 3.x or the early 4.x 
> versions,

Ah, 15..20 years ago :-)

> maybe the first incarnation of -Wempty-body or so) and I've been 
> avoiding -Wextra since that point in time. Well, maybe it got better in 
> recent years and I should give it a try again...

I'm interested in hearing the results!

My main advice is if you do not like some warnings to disable *those*,
instead of only enabling the few you found out you like.  Secondly, if
some warning is annoying, there probably is a good reason it is in -W
nonetheless!


Segher