[SLOF] [PATCH] libc: Add missing fallthrough annotation

Thomas Huth thuth at redhat.com
Sun Jan 24 16:59:22 AEDT 2021


On 22/01/2021 19.28, Philippe Mathieu-Daudé wrote:
> On Fri, Jan 22, 2021 at 6:24 PM Thomas Huth <thuth at redhat.com> wrote:
>> On 22/01/2021 18.21, Philippe Mathieu-Daudé wrote:
>>> Silence warning when cross-compiling with GCC on Debian 10:
>>>
>>>     $ s390x-linux-gnu-gcc --version
>>>     s390x-linux-gnu-gcc (Debian 8.3.0-2) 8.3.0
>>>
>>>     lib/libc/stdio/vsnprintf.c: In function 'print_format':
>>>     lib/libc/stdio/vsnprintf.c:165:11: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>
>> Is -Wimplicit-fallthrough enabled by default there? Or did you enable it?
> 
> I am using defaults.
> 
> I just checked and this also happens with QEMU CI:
> https://travis-ci.org/github/qemu/qemu/jobs/755671724#L1830

Ah, so this is not the normal SLOF build, but the s390-ccw bios using libnet 
from SLOF. That makes sense now, we're using the warning flags from QEMU there.

  Thomas



More information about the SLOF mailing list