[SLOF] [PATCH v2 2/2] usb/storage: Implement block write support

Thomas Huth thuth at redhat.com
Thu Dec 13 16:58:49 AEDT 2018

On 2018-12-12 22:10, Segher Boessenkool wrote:
> On Wed, Dec 12, 2018 at 09:14:21PM +0100, Thomas Huth wrote:
>> On 2018-12-12 15:31, Laurent Vivier wrote:
>> There is another "ELSE FALSE EXIT THEN" at the end of this function. I
>> think you've got to drop the "dir" stack item in that case, too, don't you?
> Early exits should be early, not late.  That's the point of early exits:
> it reduces nesting level, and confusion about what is on the stacks when.

Yeah, it's early now, Laurent cleaned it up by moving it to the
beginning in the first patch - I just mixed it up here again while
looking at the original source code when I reviewed the second patch.
Everything is fine in v4 of the series.


More information about the SLOF mailing list