[SLOF] [PATCH v2 2/2] usb/storage: Implement block write support

Segher Boessenkool segher at kernel.crashing.org
Thu Dec 13 08:10:18 AEDT 2018

On Wed, Dec 12, 2018 at 09:14:21PM +0100, Thomas Huth wrote:
> On 2018-12-12 15:31, Laurent Vivier wrote:
> There is another "ELSE FALSE EXIT THEN" at the end of this function. I
> think you've got to drop the "dir" stack item in that case, too, don't you?

Early exits should be early, not late.  That's the point of early exits:
it reduces nesting level, and confusion about what is on the stacks when.


More information about the SLOF mailing list