[SLOF] [RFC PATCH] usb-xhci: add keyboard support

Nikunj A Dadhania nikunj at linux.vnet.ibm.com
Thu Sep 10 21:58:38 AEST 2015


Benjamin Herrenschmidt <benh at au1.ibm.com> writes:

> On Thu, 2015-09-10 at 11:54 +0530, Nikunj A Dadhania wrote:
>> Current implementation enumerated only the USB3 ports and supported
>> USB
>> MSC device.
>> 
>> QEMU USB keyboard attached to a xhci controller appears as high speed
>> device.
>>     * Add support for scanning usb2 ports.
>>     * Add support for xhci interrupt pipes needed for keyboard
>> handling
>>     * Improve usb key fetching
>> 
>> Signed-off-by: Nikunj A Dadhania <nikunj at linux.vnet.ibm.com>
>> ---
>> 
>> Got the keyboard working on usb3. There may be some rough edges, 
>> I am testing this on my end. Thought of sending it for early review
>
> One thing to be careful about is that I noticed that QEMU
> implenmentation of XHCI doesn't implement halt properly. It basically
> says that it's halted immediately but doesn't actually terminate
> ongoing activities and DMAs ... Something to be careful about.

Oh ok, do we need some delay in the shutdown path before ending quiesce?

Regards
Nikunj



More information about the SLOF mailing list