[Skiboot] [PATCH 0/8] Implement PLDM self test

[Abhishek Singh Tomar]

Thanks for your review.

The printf in the PLDM test code is present only in case of failure. The prints seen during make check are part of the main code, not the test code.

If needed, we can plan to modify the main code to suppress prints, but that should be separately than PLDM test patch set.

________________________________________
From: Aditya Gupta <adityag at linux.ibm.com>
Sent: Wednesday, March 5, 2025 10:31 PM
To: Abhishek Singh Tomar <Abhishek.Singh.Tomar1 at ibm.com>; skiboot at lists.ozlabs.org <skiboot at lists.ozlabs.org>
Cc: abhisheksingh.tomar28 at gmail.com <abhisheksingh.tomar28 at gmail.com>; arbab at linux.ibm.com <arbab at linux.ibm.com>
Subject: Re: [Skiboot] [PATCH 0/8] Implement PLDM self test
 
All tests with `make check` passes for me.

     Tested-by: Aditya Gupta <adityag at linux.ibm.com>


Glanced over the code, seems good to me.
Few "nitpicks" can be using /**/ instead of // in patch 2/8.
And maybe printing the pldm printfs if DEBUG is enabled, or to some log
file, don't know if make check supports that or how that is done in
other tests.


Thanks
- Aditya Gupta


On 20/02/25 15:04, ABHISHEK SINGH TOMAR wrote:
> These patches contains self test for PLDM. These self test
> are not hardware dependent as they bypass hardware dependent code.
> They tries to test codeflow for following PLDM message types
> 1. PLDM FILE I/O
> 2. PLDM BIOS
> 3. PLDM PLATFORM
> 4. PLDM FRU
>
> Abhishek Singh Tomar (8):
>    core/pldm/test : Implement PLDM self test common api
>    core/pldm/test : Add self-test for PLDM file I/O message
>    core/pldm/test : Add pldm BIOS Specification Self test
>    core/pldm/test : Add self test for lid read
>    core/pldm/test : Add tests for PLDM platform PDR requests
>    core/pldm/test : Add self test for pldm platform shutdown
>    core/pldm/test : Add tests for platform poweroff and restart
>    core/pldm/test : Add PLDM FRU table self test
>
>   core/pldm/pldm.h                       |   2 +-
>   core/pldm/test/Makefile.check          |  63 ++
>   core/pldm/test/test-pldm-common.c      | 224 ++++++
>   core/pldm/test/test-pldm-fileio-bios.c | 952 +++++++++++++++++++++++++
>   core/pldm/test/test-pldm-fru.c         | 415 +++++++++++
>   core/pldm/test/test-pldm-platform.c    | 733 +++++++++++++++++++
>   6 files changed, 2388 insertions(+), 1 deletion(-)
>   create mode 100644 core/pldm/test/Makefile.check
>   create mode 100644 core/pldm/test/test-pldm-common.c
>   create mode 100644 core/pldm/test/test-pldm-fileio-bios.c
>   create mode 100644 core/pldm/test/test-pldm-fru.c
>   create mode 100644 core/pldm/test/test-pldm-platform.c
>