[Skiboot] [PATCH 0/8] Implement PLDM self test

Aditya Gupta adityag at linux.ibm.com
Thu Mar 6 04:01:57 AEDT 2025


All tests with `make check` passes for me.

     Tested-by: Aditya Gupta <adityag at linux.ibm.com>


Glanced over the code, seems good to me.
Few "nitpicks" can be using /**/ instead of // in patch 2/8.
And maybe printing the pldm printfs if DEBUG is enabled, or to some log 
file, don't know if make check supports that or how that is done in 
other tests.


Thanks
- Aditya Gupta


On 20/02/25 15:04, ABHISHEK SINGH TOMAR wrote:
> These patches contains self test for PLDM. These self test
> are not hardware dependent as they bypass hardware dependent code.
> They tries to test codeflow for following PLDM message types
> 1. PLDM FILE I/O
> 2. PLDM BIOS
> 3. PLDM PLATFORM
> 4. PLDM FRU
>
> Abhishek Singh Tomar (8):
>    core/pldm/test : Implement PLDM self test common api
>    core/pldm/test : Add self-test for PLDM file I/O message
>    core/pldm/test : Add pldm BIOS Specification Self test
>    core/pldm/test : Add self test for lid read
>    core/pldm/test : Add tests for PLDM platform PDR requests
>    core/pldm/test : Add self test for pldm platform shutdown
>    core/pldm/test : Add tests for platform poweroff and restart
>    core/pldm/test : Add PLDM FRU table self test
>
>   core/pldm/pldm.h                       |   2 +-
>   core/pldm/test/Makefile.check          |  63 ++
>   core/pldm/test/test-pldm-common.c      | 224 ++++++
>   core/pldm/test/test-pldm-fileio-bios.c | 952 +++++++++++++++++++++++++
>   core/pldm/test/test-pldm-fru.c         | 415 +++++++++++
>   core/pldm/test/test-pldm-platform.c    | 733 +++++++++++++++++++
>   6 files changed, 2388 insertions(+), 1 deletion(-)
>   create mode 100644 core/pldm/test/Makefile.check
>   create mode 100644 core/pldm/test/test-pldm-common.c
>   create mode 100644 core/pldm/test/test-pldm-fileio-bios.c
>   create mode 100644 core/pldm/test/test-pldm-fru.c
>   create mode 100644 core/pldm/test/test-pldm-platform.c
>


More information about the Skiboot mailing list