[Skiboot] [PATCH v2 3/6] plat/qemu: add support for Power11 platform

[Mahesh J Salgaonkar]

On 2025-02-05 09:09:24 Wed, Reza Arbab wrote:
> On Mon, Feb 03, 2025 at 07:18:24PM +0530, Mahesh J Salgaonkar wrote:
> > On 2025-02-03 08:19:22 Mon, Cédric Le Goater wrote:
> > > On 2/3/25 07:16, Mahesh Salgaonkar wrote:
> > > > --- a/hw/xscom.c
> > > > +++ b/hw/xscom.c
> > > > @@ -876,8 +877,19 @@ static uint8_t xscom_get_ec_rev(struct proc_chip *chip)
> > > >   	if (rev < 0)
> > > >   		return 0;
> > > > +	switch (proc_gen) {
> > > > +	case proc_gen_p9:
> > > > +		proc_gen_num = 9; break;
> > > > +	case proc_gen_p10:
> > > > +		proc_gen_num = 10; break;
> > > > +	case proc_gen_p11:
> > > > +		proc_gen_num = 11; break;
> > > > +	default:
> > > > +		proc_gen_num = -1; break;
> > > > +	}
> > > > +
> > > 
> > > This could be a little helper.
> > 
> > Sure, will add.
> 
> And when proc_gen_num is -1, please print some kind of "unknown
> processor" message instead of "P-1 DD0.0 detected":

Looking at the switch case before this one, we may never end up with -1,
and we would return from this function before hitting this switch case
if proc gen is not p9, p10 or p11. However, I agree that print message
needs correction. Will fix it in v3.

Thanks,
-Mahesh.