[Skiboot] [PATCH v2 3/6] plat/qemu: add support for Power11 platform

[Reza Arbab]

On Mon, Feb 03, 2025 at 07:18:24PM +0530, Mahesh J Salgaonkar wrote:
>On 2025-02-03 08:19:22 Mon, Cédric Le Goater wrote:
>> On 2/3/25 07:16, Mahesh Salgaonkar wrote:
>> > --- a/hw/xscom.c
>> > +++ b/hw/xscom.c
>> > @@ -876,8 +877,19 @@ static uint8_t xscom_get_ec_rev(struct proc_chip *chip)
>> >   	if (rev < 0)
>> >   		return 0;
>> > +	switch (proc_gen) {
>> > +	case proc_gen_p9:
>> > +		proc_gen_num = 9; break;
>> > +	case proc_gen_p10:
>> > +		proc_gen_num = 10; break;
>> > +	case proc_gen_p11:
>> > +		proc_gen_num = 11; break;
>> > +	default:
>> > +		proc_gen_num = -1; break;
>> > +	}
>> > +
>>
>> This could be a little helper.
>
>Sure, will add.

And when proc_gen_num is -1, please print some kind of "unknown
processor" message instead of "P-1 DD0.0 detected":

>       prlog(PR_INFO, "P%d DD%i.%i%d detected\n",
>-                      proc_gen == proc_gen_p9 ? 9 : 10,
>+                      proc_gen_num,
>                       0xf & (chip->ec_level >> 4),
>                       chip->ec_level & 0xf,
>                       rev);

-- 
Reza Arbab