[Skiboot] [PATCH v2 33/59] hw/phb5: Add initial support

Frederic Barrat fbarrat at linux.ibm.com
Mon Oct 25 23:41:23 AEDT 2021



On 24/10/2021 17:03, Cédric Le Goater wrote:
> Hello,
> 
> While looking at synchronizing the opal-api.h file with Linux,
> this difference popped out :
> 
>> diff --git a/include/opal-api.h b/include/opal-api.h
>> index 9cba35c7d..eb6d83527 100644
>> --- a/include/opal-api.h
>> +++ b/include/opal-api.h
>> @@ -799,7 +799,8 @@ enum {
>>   enum {
>>       OPAL_PHB_ERROR_DATA_TYPE_PHB3 = 2,
>> -    OPAL_PHB_ERROR_DATA_TYPE_PHB4 = 3
>> +    OPAL_PHB_ERROR_DATA_TYPE_PHB4 = 3,
>> +    OPAL_PHB_ERROR_DATA_TYPE_PHB5 = 3 /* TODO change this */
>>   };
> 
> 
> Is the diag data the same on PHB4 and PHB5 ?


Yes it is. I'm sending a patch to clean that up.

   Fred


More information about the Skiboot mailing list