[Skiboot] [PATCH v2 33/59] hw/phb5: Add initial support

Cédric Le Goater clg at kaod.org
Mon Oct 25 02:03:33 AEDT 2021


Hello,

While looking at synchronizing the opal-api.h file with Linux,
this difference popped out :

> diff --git a/include/opal-api.h b/include/opal-api.h
> index 9cba35c7d..eb6d83527 100644
> --- a/include/opal-api.h
> +++ b/include/opal-api.h
> @@ -799,7 +799,8 @@ enum {
>   
>   enum {
>   	OPAL_PHB_ERROR_DATA_TYPE_PHB3 = 2,
> -	OPAL_PHB_ERROR_DATA_TYPE_PHB4 = 3
> +	OPAL_PHB_ERROR_DATA_TYPE_PHB4 = 3,
> +	OPAL_PHB_ERROR_DATA_TYPE_PHB5 = 3 /* TODO change this */
>   };


Is the diag data the same on PHB4 and PHB5 ?

Thanks

C.


More information about the Skiboot mailing list