[Skiboot] [PATCH] FSP/NVRAM: Do not assert in vNVRAM statistics call

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Mon Oct 19 22:44:08 AEDT 2020

`msg` is valid pointer here. I don't recall why I added assert here :-(
This is not correct. We shouldn't call assert here.  Also we are not using
`msg`. Hence convert it to `__unused`.

Fixes: 19d4f98e ('FSP/NVRAM: Handle "get vNVRAM statistics" command')
Cc: skiboot-stable at lists.ozlabs.org # v5.4.x +
Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
 hw/fsp/fsp-nvram.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/hw/fsp/fsp-nvram.c b/hw/fsp/fsp-nvram.c
index 80c842407..aa17cb5e7 100644
--- a/hw/fsp/fsp-nvram.c
+++ b/hw/fsp/fsp-nvram.c
@@ -305,12 +305,11 @@ static struct fsp_client fsp_nvram_client_rr = {
 	.message = fsp_nvram_msg_rr,
-static bool fsp_vnvram_msg(u32 cmd_sub_mod, struct fsp_msg *msg)
+static bool fsp_vnvram_msg(u32 cmd_sub_mod, struct fsp_msg *msg __unused)
 	u32 cmd;
 	struct fsp_msg *resp;
-	assert(msg == NULL);
 	switch (cmd_sub_mod) {

More information about the Skiboot mailing list