[Skiboot] [PATCH] libstb: Don't exit trustedboot services multiple times

Oliver O'Halloran oohall at gmail.com
Tue May 26 17:10:26 AEST 2020

On Fri, May 1, 2020 at 9:02 AM Mauro S. M. Rodrigues
<maurosr at linux.vnet.ibm.com> wrote:
> For the very specific scenario when the fast-reboot is used, we see
> multiple error messages regarding the trusteboot measurements not being
> done.
> The way fast-reboot works is performing just fundamental operations, like
> PCI initialization, to get skiboot into good shape to boot kernel, and
> later the host's Kernel. That means fast-reboot contains data structures
> filled since last full reboot.
> In this process trustedboot is not re-initialized when, but it still tries
> to perform the STB measurements and event logging done in
> trustedboot_exit_services, showing multiple failure messages.
> This patch avoids that situation by returning earlier and logging that
> trustedboot already exited.
> If eventually something changes and trustedboot gets re-initialized during
> fast-reboot this patch also set boot_services_exited to false after every
> initialization so we always exit trustedboot whenever it get initialized.
> Signed-off-by: Mauro S. M. Rodrigues <maurosr at linux.vnet.ibm.com>

Thanks merged as 59314f312278548f2ec9f9a34ec11a67e470ab24

More information about the Skiboot mailing list