[Skiboot] [PATCH] libstb: Don't exit trustedboot services multiple times

Mauro S. M. Rodrigues maurosr at linux.vnet.ibm.com
Fri May 1 09:01:28 AEST 2020

For the very specific scenario when the fast-reboot is used, we see
multiple error messages regarding the trusteboot measurements not being

The way fast-reboot works is performing just fundamental operations, like
PCI initialization, to get skiboot into good shape to boot kernel, and
later the host's Kernel. That means fast-reboot contains data structures
filled since last full reboot.

In this process trustedboot is not re-initialized when, but it still tries
to perform the STB measurements and event logging done in
trustedboot_exit_services, showing multiple failure messages.

This patch avoids that situation by returning earlier and logging that
trustedboot already exited.

If eventually something changes and trustedboot gets re-initialized during
fast-reboot this patch also set boot_services_exited to false after every
initialization so we always exit trustedboot whenever it get initialized.

Signed-off-by: Mauro S. M. Rodrigues <maurosr at linux.vnet.ibm.com>
 libstb/trustedboot.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git libstb/trustedboot.c libstb/trustedboot.c
index 413862e639..b1f86cc709 100644
--- libstb/trustedboot.c
+++ libstb/trustedboot.c
@@ -116,6 +116,7 @@ void trustedboot_init(void)
 	trusted_init = true;
+	boot_services_exited = false;
 int trustedboot_exit_boot_services(void)
@@ -124,11 +125,15 @@ int trustedboot_exit_boot_services(void)
 	int rc = 0;
 	bool failed = false;
-	boot_services_exited = true;
 	if (!trusted_mode)
 		goto out_free;
+	if (boot_services_exited) {
+		prlog(PR_WARNING, "Trusted boot services exited before.\n");
+		goto out_free;
+	}
+	boot_services_exited = true;
 #ifdef STB_DEBUG
 	prlog(PR_NOTICE, "ev_separator.event: %s\n", ev_separator.event);
 	prlog(PR_NOTICE, "ev_separator.sha1:\n");

More information about the Skiboot mailing list