[Skiboot] [PATCH 1/2] hw/phb4: Actually enable error reporting

Oliver O'Halloran oohall at gmail.com
Fri Aug 28 14:30:54 AEST 2020


PHB3 had an errata about correctable errors and when Ben was doing the
initial PHB4 port he deleted the corresponding config write to DEVCTL.

Whoops.

Cc: skiboot-stable at lists.ozlabs.org
Signed-off-by: Oliver O'Halloran <oohall at gmail.com>
---
 hw/phb4.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/phb4.c b/hw/phb4.c
index 3f22a2c4d98f..328621917667 100644
--- a/hw/phb4.c
+++ b/hw/phb4.c
@@ -785,6 +785,7 @@ static void phb4_endpoint_init(struct phb *phb,
 	val16 |= (PCICAP_EXP_DEVCTL_NFE_REPORT |
 		  PCICAP_EXP_DEVCTL_FE_REPORT |
 		  PCICAP_EXP_DEVCTL_UR_REPORT);
+	pci_cfg_write16(phb, bdfn, ecap + PCICAP_EXP_DEVCTL, val16);
 
 	/* Enable ECRC generation and check */
 	pci_cfg_read32(phb, bdfn, aercap + PCIECAP_AER_CAPCTL, &val32);
-- 
2.26.2



More information about the Skiboot mailing list