[Skiboot] [PATCH] fsp/dump: Handle non-MPIPL scenario

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Thu Aug 27 15:25:25 AEST 2020


If MPIPL is not enabled then we will not create `/ibm,opal/dump` node
and we should continue to parse/retrieve SYSDUMP. I missed this scenario
when I fixed similar issue last time :-(

Fixes: 92b7968 (fsp: Skip sysdump retrieval only in MPIPL boot)
Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
---
 hw/fsp/fsp-dump.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/fsp/fsp-dump.c b/hw/fsp/fsp-dump.c
index 3ea353a0b..96cb45e6f 100644
--- a/hw/fsp/fsp-dump.c
+++ b/hw/fsp/fsp-dump.c
@@ -830,10 +830,10 @@ static void check_ipl_sys_dump(void)
 		if (!opal_node)
 			return;
 		dump_node = dt_find_by_path(opal_node, "dump");
-		if (!dump_node)
-			return;
-		if (dt_find_property(dump_node, "mpipl-boot"))
-			return;
+		if (dump_node) {
+			if (dt_find_property(dump_node, "mpipl-boot"))
+				return;
+		}
 	}
 
 	dump_node = dt_find_by_path(dt_root, "ipl-params/platform-dump");
-- 
2.26.2



More information about the Skiboot mailing list