[Skiboot] [PATCH 0/9] Clean up issues with opal-gard

Oliver O'Halloran oohall at gmail.com
Tue Oct 15 14:43:46 AEDT 2019


On Thu, Oct 3, 2019 at 4:01 PM Andrew Jeffery <andrew at aj.id.au> wrote:
>
> Hello,
>
> This series fixes two corruption issues that are exposed by opal-gard:
>
> * A broken offset calculation when clearing specific records in patch 1
> * Broken writes of unaligned data to ECC protected partitions in patches 2-9
>
> Patches 2-8 are cleanups that help remove noise from the actual fix contained
> in patch 9.
>
> Regression tests are introduced for both corruption cases.
>
> The fixes need to go to skiboot stable, but I'm wondering whether we want to
> squash patches 2-9 together for that? Not sure. Will follow that up after some
> feedback.
>
> Please review!

Looked ok to me. Series is merged to master as of
e08fee36a5196ca094c5fb7dd1421279b146531f.

Thanks for fixing this. I was aware there's some bugs with the
libflash's ECC handling but never got around to wading into it.

Vasant, can you pick this up for stable?


More information about the Skiboot mailing list