[Skiboot] [PATCH 0/9] Clean up issues with opal-gard
andrew at aj.id.au
Tue Oct 8 11:01:32 AEDT 2019
On Mon, 7 Oct 2019, at 19:18, Vasant Hegde wrote:
> On 10/3/19 11:23 AM, Andrew Jeffery wrote:
> > Hello,
> > This series fixes two corruption issues that are exposed by opal-gard:
> > * A broken offset calculation when clearing specific records in patch 1
> > * Broken writes of unaligned data to ECC protected partitions in patches 2-9
> > Patches 2-8 are cleanups that help remove noise from the actual fix contained
> > in patch 9.
> > Regression tests are introduced for both corruption cases.
> > The fixes need to go to skiboot stable, but I'm wondering whether we want to
> > squash patches 2-9 together for that? Not sure. Will follow that up after some
> > feedback.
> I'd prefer to pull all of them instead of squashing. That way it becomes easy
> to track.
Okay, my thought there was the intermediate cleanup commits aren't fixing any
obvious problems and so future us might be surprised by them being pulled into
stable. Squashing them into 9/9 would resolve that, but as you say it would take
us away from what's on master.
Would you like me to resend the whole series as-is to skiboot-stable@ ?
More information about the Skiboot