[Skiboot] [PATCH 05/12] fixup_spira remove incorrect endian conversion

Nicholas Piggin npiggin at gmail.com
Wed Oct 2 13:30:17 AEST 2019


Oliver O'Halloran's on October 1, 2019 1:56 pm:
> On Sun, 2019-09-29 at 17:46 +1000, Nicholas Piggin wrote:
>> Signed-off-by: Nicholas Piggin <npiggin at gmail.com>
>> ---
>>  hdata/memory.c | 3 ++-
>>  hdata/spira.c  | 2 +-
>>  2 files changed, 3 insertions(+), 2 deletions(-)
>> 
>> diff --git a/hdata/memory.c b/hdata/memory.c
>> index 9af7ae71d..2a199ae83 100644
>> --- a/hdata/memory.c
>> +++ b/hdata/memory.c
>> @@ -135,7 +135,8 @@ static bool add_address_range(struct dt_node *root,
>>  	      "on Chip 0x%x mattr: 0x%x pattr: 0x%x status:0x%x\n",
>>  	      (long long)be64_to_cpu(arange->start),
>>  	      (long long)be64_to_cpu(arange->end),
> 
>> -	      chip_id, arange->mirror_attr, mem_type, mem_status);
>> +	      chip_id, (int)be32_to_cpu(arange->mirror_attr),
> 
> Is that int cast needed?

Don't think so.

Thanks,
Nick


More information about the Skiboot mailing list