[Skiboot] [PATCH v2] chip: enable HOMER/OCC common area region in Qemu emulated PowerNV host

[Cédric Le Goater]

On 06/11/2019 10:47, Cédric Le Goater wrote:
> Hello Balamuruhan,
> 
> On 16/10/2019 11:13, Balamuruhan S wrote:
>> Recent work on Qemu adds support to emulate homer memory region and occ
>> common area region with respective device models, so remove `QUIRK_NO_PBA`
>> to enable HOMER/OCC common area region for Qemu emulated PowerNV host.
>>
>> Introduce `QUIRK_QEMU` in enum proc_chip_quirks that will be used for
>> future work.
>>
>> Signed-off-by: Cédric Le Goater <clg at kaod.org>
>> Signed-off-by: Balamuruhan S <bala24 at linux.ibm.com>
>> ---
>>  core/chip.c    | 4 ++--
>>  include/chip.h | 1 +
>>  2 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/core/chip.c b/core/chip.c
>> index 4a4a9a27..45733573 100644
>> --- a/core/chip.c
>> +++ b/core/chip.c
>> @@ -133,9 +133,9 @@ void init_chips(void)
>>  	if (dt_node_is_compatible(dt_root, "qemu,powernv") ||
>>  	    dt_node_is_compatible(dt_root, "qemu,powernv8") ||
>>  	    dt_node_is_compatible(dt_root, "qemu,powernv9")) {
>> -		proc_chip_quirks |= QUIRK_NO_CHIPTOD | QUIRK_NO_PBA
>> +		proc_chip_quirks |= QUIRK_QEMU | QUIRK_NO_CHIPTOD
> 
> The removal of QUIRK_NO_PBA seems to break our QEMU PowerNV emulation.
> What is needed exactly ? I thought PnvHomer was enough.

So it is a multichip problem  '-machine powernv8|9,num-chips=2'. 
Probably the HOMER region address of chip 2 is wrong.

C.