[Skiboot] [PATCH v2] chip: enable HOMER/OCC common area region in Qemu emulated PowerNV host

[Cédric Le Goater]

Hello Balamuruhan,

On 16/10/2019 11:13, Balamuruhan S wrote:
> Recent work on Qemu adds support to emulate homer memory region and occ
> common area region with respective device models, so remove `QUIRK_NO_PBA`
> to enable HOMER/OCC common area region for Qemu emulated PowerNV host.
> 
> Introduce `QUIRK_QEMU` in enum proc_chip_quirks that will be used for
> future work.
> 
> Signed-off-by: Cédric Le Goater <clg at kaod.org>
> Signed-off-by: Balamuruhan S <bala24 at linux.ibm.com>
> ---
>  core/chip.c    | 4 ++--
>  include/chip.h | 1 +
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/core/chip.c b/core/chip.c
> index 4a4a9a27..45733573 100644
> --- a/core/chip.c
> +++ b/core/chip.c
> @@ -133,9 +133,9 @@ void init_chips(void)
>  	if (dt_node_is_compatible(dt_root, "qemu,powernv") ||
>  	    dt_node_is_compatible(dt_root, "qemu,powernv8") ||
>  	    dt_node_is_compatible(dt_root, "qemu,powernv9")) {
> -		proc_chip_quirks |= QUIRK_NO_CHIPTOD | QUIRK_NO_PBA
> +		proc_chip_quirks |= QUIRK_QEMU | QUIRK_NO_CHIPTOD

The removal of QUIRK_NO_PBA seems to break our QEMU PowerNV emulation.
What is needed exactly ? I thought PnvHomer was enough.

Thanks,

C.

>  			| QUIRK_NO_DIRECT_CTL | QUIRK_NO_RNG;
> -		prlog(PR_NOTICE, "CHIP: Detected Qemu simulator\n");
> +		prlog(PR_NOTICE, "CHIP: Detected QEMU simulator\n");
>  	}
>  
>  	/* We walk the chips based on xscom nodes in the tree */
> diff --git a/include/chip.h b/include/chip.h
> index 9bddd38e..adb962af 100644
> --- a/include/chip.h
> +++ b/include/chip.h
> @@ -105,6 +105,7 @@ enum proc_chip_quirks {
>  	QUIRK_SLOW_SIM		= 0x00000040,
>  	QUIRK_NO_DIRECT_CTL	= 0x00000080,
>  	QUIRK_NO_RNG		= 0x00000100,
> +	QUIRK_QEMU              = 0x00000200,
>  };
>  
>  extern enum proc_chip_quirks proc_chip_quirks;
>