[Skiboot] [PATCH v2 1/6] xive: Remove xive rev field and recognize P9P

[Nicholas Piggin]

Oliver's on May 6, 2019 4:28 pm:
> On Thu, May 2, 2019 at 9:17 PM Nicholas Piggin <npiggin at gmail.com> wrote:
>>
>> All supported P9s are the revision 2 xive model, so there is no point
>> to keeping it around. This avoids P9P being reported as unknown rev
>> (which doesn't cause any other problems).
>>
>> Signed-off-by: Nicholas Piggin <npiggin at gmail.com>
>> ---
>>  hw/xive.c | 23 ++++++++++++-----------
>>  1 file changed, 12 insertions(+), 11 deletions(-)
>>
>> diff --git a/hw/xive.c b/hw/xive.c
>> index f38226523..5edcaedf5 100644
>> --- a/hw/xive.c
>> +++ b/hw/xive.c
>> @@ -365,10 +365,6 @@ struct xive {
>>         uint32_t        chip_id;
>>         uint32_t        block_id;
>>         struct dt_node  *x_node;
>> -       int             rev;
>> -#define XIVE_REV_UNKNOWN       0       /* Unknown version */
>> -#define XIVE_REV_1             1       /* P9 (Nimbus) DD1.x (not supported) */
>> -#define XIVE_REV_2             2       /* P9 (Nimbus) DD2.x or Cumulus */
> 
> 
> IIRC Pn+1 is going to have rev 3 XIVE. Are you sure we're not going to
> end up adding this again later on?

I think gen 2 (where P9 is gen 1, rev 2).

The exact name doesn't really matter, skiboot could just as well call
it REV_3 or GEN_2. But it's possible things will be a bit more
complicated. We might have a xive2 struct type, or a gen2 chip that
is running in a gen1 emulation mode. So might as well just remove it
IMO, it's trivial to add something back later if needed.

Thanks,
Nick