[Skiboot] [PATCH] asm/head: set skiboot TOC in interrupt handler entry

Oliver O'Halloran oohall at gmail.com
Tue Jul 30 14:29:39 AEST 2019


On Wed, Jul 24, 2019 at 9:25 PM Nicholas Piggin <npiggin at gmail.com> wrote:
>
> Some code runs with r2 not set to the skiboot TOC, for example the
> secureboot CVC (see call_rom_entry). If a system reset or machine
> check is taken at this time, the skiboot interrupt handler will
> crash badly rather than report it.
>
> So set the skiboot TOC into r2 in the interrupt entry code. r2 is
> already saved and restored, so in the case of recoverable exceptions,
> this will restore the correct r2 when returning to such code.
>
> This issue was found by Stewart, and this patch is based on his
> initial fix, with some modification.

Merged as 4cf05f35c9158341606e170c4a4c7a0835d7b41b


More information about the Skiboot mailing list