[Skiboot] [PATCH v2 1/2] hdata: Align SMP link definitions with current HDAT spec

Frederic Barrat fbarrat at linux.ibm.com
Wed Jul 10 01:05:57 AEST 2019


All link usage values other than GPU were unused, so there's no
functional change or backward compatibility issue.

Signed-off-by: Frederic Barrat <fbarrat at linux.ibm.com>
---
Changelog:
v2: new patch for minor cleanup


 hdata/spira.c | 2 +-
 hdata/spira.h | 9 +++++----
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/hdata/spira.c b/hdata/spira.c
index 6891a9c7..3d7e21cd 100644
--- a/hdata/spira.c
+++ b/hdata/spira.c
@@ -1370,7 +1370,7 @@ static void add_npu(struct dt_node *xscom, const struct HDIF_array_hdr *links,
 		struct dt_node *node;
 
 		/* only add a link node if this link is targeted at at device */
-		if (be32_to_cpu(link->usage) != SMP_LINK_USE_DEVICE)
+		if (be32_to_cpu(link->usage) != SMP_LINK_USE_GPU)
 			continue;
 
 		/*
diff --git a/hdata/spira.h b/hdata/spira.h
index 09de4dad..563a98c2 100644
--- a/hdata/spira.h
+++ b/hdata/spira.h
@@ -1175,10 +1175,11 @@ struct sppcrd_smp_link {
 	__be32 link_id;
 	__be32 usage;
 #define SMP_LINK_USE_NONE 	0
-#define SMP_LINK_USE_DEVICE	1
-#define SMP_LINK_USE_INTERPOSER 2
-#define SMP_LINK_USE_DRAWER	3
-#define SMP_LINK_USE_D2D	4 /* GPU to GPU */
+#define SMP_LINK_USE_GPU	1
+#define SMP_LINK_USE_OPENCAPI	2
+#define SMP_LINK_USE_INTERPOSER 3
+#define SMP_LINK_USE_DRAWER	4
+#define SMP_LINK_USE_D2D	5 /* GPU to GPU */
 	__be32 brick_id;
 	__be32 lane_mask;
 
-- 
2.21.0



More information about the Skiboot mailing list