[Skiboot] [PATCH] hdata/memory: Fix warning message

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Thu Feb 28 16:44:43 AEDT 2019


Even though we added memory to device tree, we are getting below warning.

Sample log:
[   57.136949696,3] Unable to use memory range 0 from MSAREA 0
[   57.137049753,3] Unable to use memory range 0 from MSAREA 1
[   57.137152335,3] Unable to use memory range 0 from MSAREA 2
[   57.137251218,3] Unable to use memory range 0 from MSAREA 3


Fixes: 4822a7ba (hdata/memory: Add NVDIMM support)
CC: Oliver O'Halloran <oohall at gmail.com>
Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
---
 hdata/memory.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hdata/memory.c b/hdata/memory.c
index 1ac03c137..a85f4eba9 100644
--- a/hdata/memory.c
+++ b/hdata/memory.c
@@ -608,7 +608,7 @@ static void get_msareas(struct dt_node *root,
 				status = GETFIELD(PHYS_ATTR_STATUS_MASK, attr);
 			}
 
-			if (add_address_range(root, id, arange, type, status))
+			if (!add_address_range(root, id, arange, type, status))
 				prerror("Unable to use memory range %d from MSAREA %d\n", j, i);
 
 			arange = (void *)arange + be32_to_cpu(arr->esize);
-- 
2.14.3



More information about the Skiboot mailing list