[Skiboot] [RFC v2] Add support for GLIBC style endianess detection

Stewart Smith stewart at linux.vnet.ibm.com
Thu Feb 28 14:38:53 AEDT 2019


Akshay Adiga <akshay.adiga at linux.vnet.ibm.com> writes:
> Add GLIBC style endianess check in $(SRC)/include/endian.h
>
> On doing so, extract-gcov.c fails to build.
>
> Problem : extract-gcov.c is built using HOSTCC , but Makefile.check 
> generically adds $(SRC)/include to include path causing the issue.
>
> HOSTCC should not include $(SKIBOOT)/include/ files and include glibc files.
>
> Signed-off-by: Akshay Adiga <akshay.adiga at linux.vnet.ibm.com>
> ---
>  core/test/Makefile.check   |  2 +-
>  include/endian.h           | 13 +++++++++++++
>  libstb/test/Makefile.check |  2 +-
>  3 files changed, 15 insertions(+), 2 deletions(-)
>  create mode 100644 include/endian.h

(Looking through old patches sitting in patchwork).


I'm not sure what the benefit of this is at the moment? What was the
reasoning behind the patch?

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list