[Skiboot] [PATCH 2/6] sparse: symbol 'xive_buddy_lock/xive_vp_buddy' was not declared. Should it be static?

Stewart Smith stewart at linux.ibm.com
Mon Feb 25 16:24:32 AEDT 2019


Yes they should.

Signed-off-by: Stewart Smith <stewart at linux.ibm.com>
---
 hw/xive.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/xive.c b/hw/xive.c
index 05e5531cbfca..e7d6f8770c88 100644
--- a/hw/xive.c
+++ b/hw/xive.c
@@ -1,4 +1,4 @@
-/* Copyright 2016 IBM Corp.
+/* Copyright 2016-2019 IBM Corp.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -595,8 +595,8 @@ static uint32_t xive_chip_to_block(uint32_t chip_id)
 
 /* VP allocation */
 static uint32_t xive_chips_alloc_bits = 0;
-struct buddy *xive_vp_buddy;
-struct lock xive_buddy_lock = LOCK_UNLOCKED;
+static struct buddy *xive_vp_buddy;
+static struct lock xive_buddy_lock = LOCK_UNLOCKED;
 
 /* VP# decoding/encoding */
 static bool xive_decode_vp(uint32_t vp, uint32_t *blk, uint32_t *idx,
-- 
2.20.1



More information about the Skiboot mailing list