[Skiboot] [PATCH 4/6] sparse: symbol 'procedure_*' was not declared. Should it be static?

Stewart Smith stewart at linux.ibm.com
Mon Feb 25 16:24:34 AEDT 2019


Yes they should. Do so by adding static to the macro.

Signed-off-by: Stewart Smith <stewart at linux.ibm.com>
---
 hw/npu-hw-procedures.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/npu-hw-procedures.c b/hw/npu-hw-procedures.c
index cabc9c99d8bd..ec1f72b8ee79 100644
--- a/hw/npu-hw-procedures.c
+++ b/hw/npu-hw-procedures.c
@@ -1,4 +1,4 @@
-/* Copyright 2013-2015 IBM Corp.
+/* Copyright 2013-2019 IBM Corp.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -31,7 +31,7 @@ struct procedure {
 };
 
 #define DEFINE_PROCEDURE(NAME, STEPS...)		\
-	struct procedure procedure_##NAME =		\
+	static struct procedure procedure_##NAME =	\
 	{.name = #NAME, .steps = {NAME, ##STEPS}}
 
 #define PROCEDURE_INPROGRESS	(1 << 31)
-- 
2.20.1



More information about the Skiboot mailing list