[Skiboot] [PATCH 2/2] astbmc: Use oem hiomap ipmi command for bmc_sw_ami

Stewart Smith stewart at linux.ibm.com
Tue Feb 19 14:56:38 AEDT 2019

Lei YU <mine260309 at gmail.com> writes:
>> So I guess we have "problem" for machines like Romulus where we can
>> "genuinely" be running either OpenBMC or AMI BMC firmware?
> That seems to be true.
> Except for the "name", the difference between bmc_plat_ast2500_ami and
> bmc_plat_ast2500_openbmc is the `bmc_sw_config` struct, which defines 3 oem
> IPMI commands:
>   1     uint32_t ipmi_oem_partial_add_esel;
>   2     uint32_t ipmi_oem_pnor_access_status;
>   3     uint32_t ipmi_oem_hiomap_cmd;
> * Luckily, AMI BMC uses the same oem command for ipmi_oem_partial_add_esel, so
>    that's OK.
> * OpenBMC has no ipmi_oem_pnor_access_status command, so Romulus PNOR loses
>    this function.

This command is useless on P9 though, as mboxd should mediate access
between host and BMC. Having this OEM command on P9 systems either means
the BMC code is buggy or it's just extra locking for the fun of it.

That being said, there should be some way of detecting it and using the
right structure (even if they're the same), so that we at least print
out the right BMC vendor and can (inevitably) add in work-arounds for
buggy BMC firmware.

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list