[Skiboot] [PATCH 2/2] astbmc: Use oem hiomap ipmi command for bmc_sw_ami

[Stewart Smith]

"Andrew Jeffery" <andrew at aj.id.au> writes:
> On Mon, 18 Feb 2019, at 16:56, Lei YU wrote:
>> After BMC uses hiomap for PNOR access, skiboot needs to use oem hiomap
>> IPMI command to access PNOR.
>> 
>> Tested on Palmetto with OpenBMC + mboxd and verify the skiboot could
>> access PNOR correctly and is able to boot to petitboot.
>> 
>> Signed-off-by: Lei YU <mine260309 at gmail.com>
>> ---
>>  platforms/astbmc/common.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/platforms/astbmc/common.c b/platforms/astbmc/common.c
>> index bc0e58f..faa73e2 100644
>> --- a/platforms/astbmc/common.c
>> +++ b/platforms/astbmc/common.c
>> @@ -459,6 +459,7 @@ void astbmc_exit(void)
>>  const struct bmc_sw_config bmc_sw_ami = {
>
> How do we detect what firmware the BMC is running? Because it's a bit
> misleading to use the _ami struct when we've only tested OpenBMC.

Currently it's hard coded per platform.

It instead should be detected, probably from an 'mc info' command, but
the fun of that is that not every vendor actually puts anything sensible
there, so it's a bit YOLO.

-- 
Stewart Smith
OPAL Architect, IBM.