[Skiboot] [PATCH] hw/p8-i2c: Fix i2c request timeout

Stewart Smith stewart at linux.ibm.com
Thu Sep 27 17:14:15 AEST 2018


Frederic Barrat <fbarrat at linux.ibm.com> writes:
> Commit eb146fac9685 ("core/i2c: Move the timeout field into
> i2c_request") simplified a bit how a request timeout is
> handled. However there's now some confusion between milliseconds and
> timebase increments when defining or using the timeout values, which
> breaks i2c requests made for opencapi, and probably others too.
>
> This patch declares all the timeout in milliseconds and just converts
> to timebase at the end of the chain, as needed.
>
> Signed-off-by: Frederic Barrat <fbarrat at linux.ibm.com>
> ---
>  hw/p8-i2c.c   | 10 ++++------
>  include/i2c.h |  2 +-
>  2 files changed, 5 insertions(+), 7 deletions(-)

Thanks, merged to master as of a800fa35b8222996a634baeec27cd2369f7619f5

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list